-
Notifications
You must be signed in to change notification settings - Fork 509
Log deeplink to trace on AgentOps dashboard. #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dot-agi
requested changes
Mar 24, 2025
Member
dot-agi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment regarding the APP_URL.
Tested it, URL looks good!
Contributor
Author
|
Updated this to generate hex strings which matches the dashboard format (not UUID). |
dot-agi
approved these changes
Mar 24, 2025
tcdent
added a commit
that referenced
this pull request
Mar 24, 2025
* Log deeplink to trace on AgentOps dashboard. * Test coverage, type checking. * Get app_url from config. * Don't format trace_id in the URL as a UUID, just a hex string.
dot-agi
added a commit
that referenced
this pull request
Mar 24, 2025
* Fix: Improve serialization of completions/responses in Agents SDK instrumentation Co-Authored-By: [email protected] <[email protected]> * Fix: Improve serialization of completions/responses in Agents SDK instrumentation Co-Authored-By: [email protected] <[email protected]> * Tests for completions. * Separate OpenAI tests into `completion` and `responses` * Refactor completions and responses unit tests. * agents SDK test using semantic conventions. * semantic conventions in openai completions and responses tests * Exporter refactor and generalization. standardization and simplification of version of values into semantic types. * Continued refactor of Agents instrumentor. Usurp third-party implementation. * Semantic conventions for messages. * Tools for generating real test data from OpenAI Agents. * support tool calls and set of responses. missing import * reasoning tokens, semantic conventions, and implementation in OpenAI agent responses. * populate agents SDK tests with fixture data. Simplify fixture data generation tooling. increased test coverage * Add chat completion support to openai_agents. Cleanup OpenAI agents instrumentation. * Agents instrumentor cleanup. * Cleanup. * Cleanup init. * absolute import. * fix breaking error. * Correct naming * rename * Refactor completions to always use semantic conventions. * More robust output * use openai_agents tracing api to gather span data. * Agents associates spans with a parent span and exports. * OpenAi responses instrumentor. * Delete examples/agents-examples/basic/hello_world.py * pass strings to serialize and return them early. * deduplication and better hierarchy. simplification of tests. separation of concerns. * Notes and working documents that should not make it into main. * more descriptive debug messaging in OpenAI Agents instrumentor * pertinent testing information in claude.md. * better version determination for the library. * Test for generation tokens as well. * Cleanup attribute formatting to use modular function format with specific responsibilites. Spans are now nested and started/ended at the correct time. Tests generate fixture data from the live API for OpenAI agents. * Remove duplicated model export from processor. * nest all spans under the parent_trace root span and open and close the root span only after execution is complete * clean up common attributes parsing helpers. * Simplify processor. * Cleanup exporter. * Cleanup instrumentor * Cleanup attributes * Update README and SPANS definition. Add example with tool usage. * Fix tool usage example. * Get completion data on outputs. * Delete notes * Fix tests for attributes. Rewmove debug statements. * Implement tests for OpenAi agents. * Better naming for spans. * Openai Response type parsing improvements. * Cleanup exporter imports and naming. * Handoff agent example. * Cleanup imports on common. * Disable openai completions/responses tests. TODO probably delete these. * Disable openai responses intrumentor; it is handled inside openai_agents exclusively for now. * Add note about enabling chat.completions api instead of responses. * Move exporter convention notes to README * Update tests. * Disable openai responses instrumentation test. * Skip `parse` serialization tests. * Cleanup openai responses instrumention and tests; will be included in a separate PR. * Resolve type checking errors. * get correct library version * remove debug statements and import LIBRARY_VERSION * Log deeplink to trace on AgentOps dashboard. (#879) * Log deeplink to trace on AgentOps dashboard. * Test coverage, type checking. * Get app_url from config. * Don't format trace_id in the URL as a UUID, just a hex string. --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Pratyush Shukla <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
trace_id_to_uuidis the correct format for the dashboard. *This needs to be a hex string, but not a UUID. *